emacs
Let the flamewars begin.
Not from me. I'm well accustomed to vi and variants but I if need to spend all day digging into code to root cause a problem, emacs is easier for me to navigate things.
I agree with others in this thread that the original question is hard without qualifiers, so with my qualifier of "my daily driver system used for everything from writing code, surfing the web, emails, editing photos", my must haves are:
drm-kmod on the intel systems, appropriate nvidia-driver on others
WindowMaker as the "DE" (yes, it's not) and the attendent X parts and widgets like wmCalClock and wmnd
urxvt is my preferred term app but xterm works just fine
claws-mail as imap email reader
darktable for the photo stuff
gimp
gnucash to do the household bookkeeping
xpdf or evince-lite for pdf viewers
openvpn to get to $WORK resources
smartmontools
Best thing you can do is once a system is "perfect" save the output of "pkg prime-list" and use that to create new systems.