14.5 does not build (unused variable)

PMc

PMc

Code: 
/usr/src/stand/common/gfx_fb.c:270:14: error: unused variable 'ptr' [-Werror,-Wunused-variable]
  270 |         const char *ptr;
      |                     ^~~

From the code it looks like this is just true: the variable is unused.
 
Comment it out to see the effect? Or add a bogus assignment to make it look used.
It looks like it should be something in the same file. It's referenced multiple times in the 15.1 version.
 
MG said:
Comment it out to see the effect? Or add a bogus assignment to make it look used.
Click to expand...
Sure. Running currently.

But the bug is elsewhere. This file is apparently unchanged since 2026-04-12.
14.5-BETA1 was announced 2026-08-09, then BETA2, BETA3, RC1 and RELEASE.
And over all these, nobody ever did run a buildworld?!? Then how was the release created?

Something seriousely doesn't figure.
 
On what platform are you building (version)? And also important: did you apply any customizations in either /etc/make.conf and/or /etc/src.conf?

Because I build 14.5 myself back in the day and had 0 issues with the build process.
 
  • Thanks
Reactions: PMc
ShelLuser said:
On what platform are you building (version)? And also important: did you apply any customizations in either /etc/make.conf and/or /etc/src.conf?

Because I build 14.5 myself back in the day and had 0 issues with the build process.
Click to expand...
Yes, this likely comes from an obsolete option in /etc/src.conf, that seems to include some untested code.
 
PMc said:
Yes, this likely comes from an obsolete option in /etc/src.conf, that seems to include some untested code.
Click to expand...
Maybe a tip... as soon as I checked out a new version of the source tree one of the first things I do is run man -M share/man src.conf from within /usr/src. Then roughly compare all that against /etc/src.conf.

This can become get bit tedious (programs like 'screen' or 'tmux' can help out a lot here) but it can be a solid way to detect such possible issues early on.
 
PMc said:
But the bug is elsewhere. This file is apparently unchanged since 2026-04-12.
14.5-BETA1 was announced 2026-08-09, then BETA2, BETA3, RC1 and RELEASE.
And over all these, nobody ever did run a buildworld?!? Then how was the release created?
Click to expand...
git blame shows this:
4bb6ec63dace8 (Kyle Evans 2025-08-21 22:48:14 -0500 270) const char *ptr;
 
You must log in or register to reply here.
Back
Top