After the transition to git I'm in the process of updating a port (net/intel-ix-kmod), exercising creating patches with devel/git, to submit it afterwards. Following the Porters Handbook one of the procedures in testing the port is checking it with ports-mgmt/portlint (chapters 3.5 Checking the Port with portlint and 10.2. Portlint).
After making the changes to the Makefile, I run ports-mgmt/portlint with the result having FATAL warnings. Running it on the original, unmodified port has the same outcome:
Regarding the FATAL about
Regarding the FATAL warnings of placement in the wrong section, if I compare Chapter 15. Order of Variables in Port Makefiles (bsd.port.mk as well) and the blocks in the original ports Makefile, they check out. I tested ports-mgmt/portlint on other ports and a lot of them returned FATAL warnings similar to the above.
Is ports-mgmt/portlint outdated and not anymore fit for use fore testing ports? Or am I hitting here a bug? No bug report found with this incident. Before submitting a PR, does someone know something more about this which may clarify that behavior?
I have installed ports-mgmt/portlint from a shallow cloned ports tree and updated main HEAD before. The port was updated last on 2021-04-06.
After making the changes to the Makefile, I run ports-mgmt/portlint with the result having FATAL warnings. Running it on the original, unmodified port has the same outcome:
Code:
/usr/ports/net/intel-ix-kmod # portlint -A
FATAL: Makefile: [2]: header should be followed by $FreeBSD$.
WARN: Makefile: NETMAP_AUTO is listed in OPTIONS_DEFINE, but no PORT_OPTIONS:MNETMAP_AUTO appears in this slave Makefile. Make sure it appears in the master's Makefile.
WARN: Makefile: NETMAP_ON is listed in OPTIONS_DEFINE, but no PORT_OPTIONS:MNETMAP_ON appears in this slave Makefile. Make sure it appears in the master's Makefile.
WARN: Makefile: NETMAP_OFF is listed in OPTIONS_DEFINE, but no PORT_OPTIONS:MNETMAP_OFF appears in this slave Makefile. Make sure it appears in the master's Makefile.
FATAL: Makefile: no $FreeBSD$ line in comment section.
WARN: Makefile: new ports should not set PORTREVISION.
WARN: Makefile: new ports should not set PORTEPOCH.
FATAL: Makefile: extra item "DISTFILES" placed in the MAINTAINER section.
FATAL: Makefile: extra item "_MAN_SOURCE" placed in the MAINTAINER section.
FATAL: Makefile: extra item "MAINTAINER" placed in the LICENSE section.
FATAL: Makefile: extra item "COMMENT" placed in the LICENSE section.
6 fatal errors and 5 warnings found.
$FreeBSD$
, those keywords are removed from the Makefiles.Regarding the FATAL warnings of placement in the wrong section, if I compare Chapter 15. Order of Variables in Port Makefiles (bsd.port.mk as well) and the blocks in the original ports Makefile, they check out. I tested ports-mgmt/portlint on other ports and a lot of them returned FATAL warnings similar to the above.
Is ports-mgmt/portlint outdated and not anymore fit for use fore testing ports? Or am I hitting here a bug? No bug report found with this incident. Before submitting a PR, does someone know something more about this which may clarify that behavior?
I have installed ports-mgmt/portlint from a shallow cloned ports tree and updated main HEAD before. The port was updated last on 2021-04-06.