C How to posixify vtoycli

[balanga]

Can anyone have a quick look and suggest how easy it would be to pozixify vtoycli?

Ventoy/vtoycli/vtoycli.c at master · ventoy/Ventoy

A new bootable USB solution. Contribute to ventoy/Ventoy development by creating an account on GitHub.

github.com

 

[cracauer@]

Gesundheit? What's with the name?

Anyway, looks like a good amount of Linuxisms. Some bad code such as omitting error checking on system calls. Have seen worse, but it will be pain to port a program that omits basic error checking.

I can't answer your question directly since I don't know what "pozixify" is supposed to mean.

 

[balanga]

Gesundheit? What's with the name?

I can't answer your question directly since I don't know what "pozixify" is supposed to mean.

Sorry... I spelt it wrong.

 

[smithi]

Sorry... I spelt it wrong.

What's it supposed to mean if you spell it right?

 

[balanga]

What's it supposed to mean if you spell it right?

Basically, 'to get rid of Linuxisms' and make it POSIX compliant, but it sounds like this would involve more than adding few if __FreeBSD statements.

 

[cracauer@]

You can't implement partition manager functionality purely with Posix. You could port this to BSDs. But as I said it is a pain to port software that omits error checking.

 

[balanga]

You can't implement partition manager functionality purely with Posix. You could port this to BSDs. But as I said it is a pain to port software that omits error checking.

Looking at the code more closely, it looks like some functions can easily be re-written using native FreeBSD commands, eg

diskinfo /dev/ada0 | cut -f 3

seems to be the equivalent of:-

get_disk_size_in_byte