Setting maintainer-approval flag on bugzilla

J

jonyepsilon

Apologies for the rudimentary question, but searching has not yielded the answer.

Someone has submitted a patch to a port that I am the maintainer for. This is my first time approving a patch. I can't for the life of me figure out how to set the maintainer-approval flag! I can see that if I click on the details link by the patch file that the flag is there, and I can change its value. But if I then submit, or add a comment and submit ... nothing seems to change.

If someone could put me out of my misery, I would be most appreciative.
 
Maintainer feedback flag is +, but maintainer approval for the attached patch is still X. You need to click "Details" link at the right of the patch on Attachments table, then, change Maintainer approval near the end of shown page to +.
 
And you need to look for a committer to be assigned and commit the patch.
If you're in hurry (i.e., including security fixes), freebsd-ports ML would be a good place for it.
 
SirDice said:
You have to change the flag (to +), AND provide a comment, then click on submit.
Click to expand...
Sorry, my wording was sloppy. That's what I tried after first trying just adding maintainer-approval and submitting. I just tried that again and the flag doesn't seem to stick for me, although the comment does.

Another kind soul has added the flag, so it's possibly better just to chalk this up to weirdness unless other people see the same problem.
 
You must log in or register to reply here.
Back
Top