Missing background in thread view on mobile devices

[SirDice]

All pages (front, threads, forums, etc) are dynamically generated based on templates and macros. All pages use the same "header" template to generate that top header of a page.

Right, found some of the other styles that are in that javascript, like div#freebsd_headerlogoleft and div#freebsd_menu. In the same file I did find #freebsd_headercontainer but that has no mention of background-image:. Haven't found div#freebsd_headercontainer yet.

Reading through the javascript a bit, there's this bit of code:

$container=e("div#freebsd_headercontainer")
{...}
$container.append('<button id="btn-hamburger">

In short, the javascript mucks around with the style client-side. The search continues.

 

[SirDice]

All pages (front, threads, forums, etc) are dynamically generated based on templates and macros. All pages use the same "header" template to generate that top header of a page.

So why does this work for the front page but not any other? That's obvious once you look at the URLs. That background URL is relative, it should be absolute. It works on the front page because https://<site>/<relative url> accidentally accesses the right URL. But it fails on the others due to https://<site>/<some subpart>/<relative url> not existing.

 

[covacat]

just add a / at the begining of the url and be done with it
it will break if the forum is in a subdir like freebsd.org/forums/ but as it isnt will work

 

[covacat]

if the url is specified in a css file the url is relative to the path from which the css was loaded
if inserted from js i have no idea where the base is considered

 

[SirDice]

just add a / at the begining of the url and be done with it

Yes. That's what I'm trying to do. But I need to find where this bloody url is defined before I can add the slash.

if the url is specified in a css file the url is relative to the path from which the css was loaded
if inserted from js i have no idea where the base is considered

That javascript is generated based on the "Style properties", "Styles" and/or "Templates" I can edit in the admin panel. So somewhere among a gazillion macros I need to find 1) where background: is added/set in the div#freebsd_headercontainer, and 2) I need to figure out where it's getting the URL from.

 

[covacat]

from outside is in https://forums.freebsd.org/js/freebsd/freebsd-forums-mobile-layout-fixer-xf2.min.js
dunno how the things are from the backend but probably it has a js dir where it resides

 

[SirDice]

One thing I'm realizing, those pages, javascripts and whatnot are dynamically generated. But you're not going to do all this generating on every request as that would probably burn down the webserver pretty quickly. You generate those once, then cache them. The basic structure is the same for every request. So I'm thinking some old copy is cached, that's why I can't find it in the actual style properties and templates in the admin panel.

 

[freethread]

SirDice I solved this but Firefox say some styles are inline styles. However I don't know how can be really solved.

 

[drhowarddrfine]

The problem is created at this point in the CSS:

@media screen and (max-width: 429px)
div#freebsd_headerlogoleft {
    width: 212px;
    overflow: hidden;
}

That appears to be generated somewhere in this mess: https://forums.freebsd.org/css.php?css=public:normalize.css,public:fa.css,public:core.less,public:app.less&s=3&l=1&d=1697218962&k=fd2707813a35c67cbd7dd3d9777545282232f1cc

The width being set to 212px causes the collapse of that element. Remove that and the problem disappears.

 

[eternal_noob]

The foundation must be quite busy if they can't fix even minor issues like this one.

 

[grahamperrin]

The foundation must be quite busy if they can't fix even minor issues like this one.

Please, don't conflate.

FreeBSD Foundation people:

• <https://freebsdfoundation.org/about-us/board-of-directors/>
• <https://freebsdfoundation.org/about-us/staff/>

Administrators of The FreeBSD Forums:

• <https://www.freebsd.org/administration/#t-forum-admins>

 

[drhowarddrfine]

eternal_noob These issues often aren't minor. Especially considering the current state of the markup. It was generated by people long ago who had little time to understand how these thing work if they worked well at all and it's not properly laid out at all.