How to make code change in a port and then reinstall?

[Aknot]

I have tried to make changes to the port textproc/php84-xsl, but must be missing something?!

I don't have a patch, but I'm guessing I should create one myself, with the code change, right?

I have tried the following:

1. cd /usr/ports/textproc/php84-xsl
2. make extract
3. cd work/php-8.4.19/ext/xsl/
4. cp  php_xsl.c php_xsl.orig
5. mcedit php_xsl.c and make desired the changes (see link below)
6. cd ../../../ && make makepatch

But that only creates a lot of empty files and directories?!

The change I want to do is the following:

Fix GH-21600: Remove xsltCleanupGlobals call in ext/xsl MSHUTDOWN. by devnexen · Pull Request #21610 · php/php-src

The call to xsltCleanupGlobals() during module shutdown can cause a segfault in xmlHashFree() when freeing libxslt internal hash tables. This is the same class of shutdown cleanup issue that led to...

github.com

Thanks,

 

[MG]

Not sure if this is the problem but does removing some dot files in the work directory have effect? .compile_done, .configure_done, etc...

 

[Alain De Vos]

make a patch file ?

 

[Charlie_]

Edit:

diff --git a/textproc/php84-xsl/Makefile b/textproc/php84-xsl/Makefile
index 64d8e7f98b..be3080a27b 100644
--- a/textproc/php84-xsl/Makefile
+++ b/textproc/php84-xsl/Makefile
@@ -4,6 +4,11 @@ MASTERDIR=     ${.CURDIR}/../../lang/php84

 PKGNAMESUFFIX= -xsl

+PATCH_SITES=   https://github.com/php/php-src/pull/21610/commits/
+PATCHFILES=    7fec72c74af072f8a8170b8929a03ee335a0feb4.patch:-p3
+
+DISTINFO_FILE= ${.CURDIR}/distinfo
+
 post-patch:
        ${REINPLACE_CMD} -e \
                's|#include "../dom/xml_common.h"|#include "ext/dom/xml_common.h"|g' \
diff --git a/textproc/php84-xsl/distinfo b/textproc/php84-xsl/distinfo
new file mode 100644
index 0000000000..78d1d2cf33
--- /dev/null
+++ b/textproc/php84-xsl/distinfo
@@ -0,0 +1,5 @@
+TIMESTAMP = 1775301156
+SHA256 (php-8.4.19.tar.xz) = 11f7164ab26d356c31f94d3d69cc0e0707d5d2d6494a221aaeae307c08eaaa1c
+SIZE (php-8.4.19.tar.xz) = 13684456
+SHA256 (7fec72c74af072f8a8170b8929a03ee335a0feb4.patch) = ce8ae9129e3375b47d326bf7313d3d62101e59eec9597672b0ca26cf43d085ff
+SIZE (7fec72c74af072f8a8170b8929a03ee335a0feb4.patch) = 1056