Solved git PRs for port updates? other "process" questions

[oodler]

It's been many moons since I've submitted an update to a port, and am looking for focus almost entirely on Perl related (p5-*) updates - simple at first, but could move into hairier stuff. Mixing my 2 loves, Perl and FreeBSD seems to make a lot of sense for me right now.

Anyway, I was re-familarizing myself with the process of submitting a patch (https://docs.freebsd.org/en/books/porters-handbook/book/#port-upgrading), and saw that ports is now in a git repo.

But I could not see if there was a git-based approach to submit a patch (i.e., as in an actual pull-request) other than the instructions on generating a patch using git itself for submission via https://bugs.freebsd.org/bugzilla/enter_bug.cgi; which leads me to my final question, is there a way to submit patches via commandline or are we reduced to using a browser-based web form? I think like many, the environment I am using to create these patches is headless with no GUI in sight.

Cheers,

 

[msplsh]

Github uses PRs but github is simply a replica. Most stuff is seems to be done with patchable diffs. If you want to use the command line exclusively, I think you're going to need to have a commit bit or something similar.

Have you looked at this?

Phabricator - FreeBSD Wiki

 

[Cath O'Deray]

… a git-based approach to submit a patch (i.e., as in an actual pull-request) …

Not yet. I hope for it to be an option in the future.

Warner Losh / FreeBSD workflow working group · GitLab

This project collects together the notes for the FreeBSD workflow working group.

gitlab.com

(I haven't caught up with things there and thereabouts.)

<https://cgit.freebsd.org/ports/commit/?id=352af02b389202ac426ecf026ac65bff7c61bd41> was an outcome of a pull request, and the PR arose from me promising (months earlier) to do some work. I simply could not have done it without GitHub, but this shouldn't set a precedent; PRs may be frowned upon because (amongst other things) they can create extra work for the committer.

 

[Cath O'Deray]

PS with Thunderbird I found a link to a short Phabricator workflow with Git thread, under <https://lists.freebsd.org/archives/freebsd-git/2021-August/index.html#msg37>.

 

[oodler]

Just a note about a workflow I've settled on (I think). Since my main question had to do with finding a workflow that worked for me, I think that it's sufficient for me to use a forked ports repo on github to contain my changes from my test environment; then I can just pull those changes to a desktop machine with a browser, create the diff from git itself as prescribed in the documentation; then use a web browser to upload that patch through the bug reporting system.

 

[oodler]

Final note, this process worked out quite well for me.