Solved Build failed samba416 or samba419

Hi.

I'm used to build net/samba416 and net/samba419 without issues.
However, since 2024/09/30, I can't build them. I didn't change any options for a while. Last builds were OK (last month). So, I guess the issue is elsewhere?

While building net/samba416:
Code:
[2496/3903] Compiling libcli/smbreadline/smbreadline.c
runner ['cc', '-D_SAMBA_BUILD_=4', '-DHAVE_CONFIG_H=1', '-O2', '-pipe', '-DLIBICONV_PLUG', '-fno-color-diagnostics', '-fstack-protector-strong', '-isystem', '/usr/local/include', '-fno-strict-aliasing', '-fno-omit-frame-pointer', '-MMD', '-D_GNU_SOURCE=1', '-D_XOPEN_SOURCE_EXTENDED=1', '-DHAVE_CONFIG_H=1', '-fPIC', '-D__STDC_WANT_LIB_EXT1__=1', '-D_REENTRANT', '-fstack-protector-strong', '-fstack-clash-protection', '-DSTATIC_SMBREADLINE_MODULES=NULL', '-DSTATIC_SMBREADLINE_MODULES_PROTO=extern void __SMBREADLINE_dummy_module_proto(void)', '-Ilibcli/smbreadline', '-I../../libcli/smbreadline', '-Iinclude/public', '-I../../include/public', '-Isource4', '-I../../source4', '-Ilib', '-I../../lib', '-Isource4/lib', '-I../../source4/lib', '-Isource4/include', '-I../../source4/include', '-Iinclude', '-I../../include', '-Ilib/replace', '-I../../lib/replace', '-I.', '-I../..', '-I/usr/local/include', '../../libcli/smbreadline/smbreadline.c', '-c', '-o/wrkdirs/usr/ports/net/samba416/work-default/samba-4.16.11/bin/default/libcli/smbreadline/smbreadline.c.1.o', '-DLIBICONV_PLUG', '-isystem', '/usr/local/include']
../../libcli/smbreadline/smbreadline.c:139:38: warning: 'CPPFunction' is deprecated [-Wdeprecated-declarations]
  139 |                 rl_attempted_completion_function = RL_COMPLETION_CAST completion_fn;
      |                                                    ^
../../lib/replace/system/readline.h:50:31: note: expanded from macro 'RL_COMPLETION_CAST'
   50 | #  define RL_COMPLETION_CAST (CPPFunction *)
      |                               ^
/usr/local/include/readline/rltypedefs.h:38:50: note: 'CPPFunction' has been explicitly marked deprecated here
   38 | typedef char **CPPFunction (void) __attribute__((deprecated));
      |                                                  ^
../../libcli/smbreadline/smbreadline.c:139:36: error: incompatible function pointer types assigning to 'rl_completion_func_t *' (aka 'char **(*)(const char *, int, int)') from 'CPPFunction *' (aka 'char **(*)(void)') [-Wincompatible-function-pointer-types]
  139 |                 rl_attempted_completion_function = RL_COMPLETION_CAST completion_fn;
      |                                                  ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning and 1 error generated.

Waf: Leaving directory `/wrkdirs/usr/ports/net/samba416/work-default/samba-4.16.11/bin/default'
Build failed
 -> task in 'SMBREADLINE' failed with exit status 1:
    {task 48861163505936: c smbreadline.c -> smbreadline.c.1.o}
['cc', '-D_SAMBA_BUILD_=4', '-DHAVE_CONFIG_H=1', '-O2', '-pipe', '-DLIBICONV_PLUG', '-fno-color-diagnostics', '-fstack-protector-strong', '-isystem', '/usr/local/include', '-fno-strict-aliasing', '-fno-omit-frame-pointer', '-MMD', '-D_GNU_SOURCE=1', '-D_XOPEN_SOURCE_EXTENDED=1', '-DHAVE_CONFIG_H=1', '-fPIC', '-D__STDC_WANT_LIB_EXT1__=1', '-D_REENTRANT', '-fstack-protector-strong', '-fstack-clash-protection', '-DSTATIC_SMBREADLINE_MODULES=NULL', '-DSTATIC_SMBREADLINE_MODULES_PROTO=extern void __SMBREADLINE_dummy_module_proto(void)', '-Ilibcli/smbreadline', '-I../../libcli/smbreadline', '-Iinclude/public', '-I../../include/public', '-Isource4', '-I../../source4', '-Ilib', '-I../../lib', '-Isource4/lib', '-I../../source4/lib', '-Isource4/include', '-I../../source4/include', '-Iinclude', '-I../../include', '-Ilib/replace', '-I../../lib/replace', '-I.', '-I../..', '-I/usr/local/include', '../../libcli/smbreadline/smbreadline.c', '-c', '-o/wrkdirs/usr/ports/net/samba416/work-default/samba-4.16.11/bin/default/libcli/smbreadline/smbreadline.c.1.o', '-DLIBICONV_PLUG', '-isystem', '/usr/local/include']
*** Error code 1

Stop.
make: stopped in /usr/ports/net/samba416
=>> Cleaning up wrkdir
===>  Cleaning for samba416-4.16.11_5
build of net/samba416@default | samba416-4.16.11_5 ended at Wed Oct  2 10:10:45 CEST 2024
build time: 00:10:32
!!! build failure encountered !!!

While building net/samba419:
Code:
[2398/3358] Compiling libcli/smbreadline/smbreadline.c
runner ['cc', '-D_SAMBA_BUILD_=4', '-DHAVE_CONFIG_H=1', '-O2', '-pipe', '-DLIBICONV_PLUG', '-fno-color-diagnostics', '-fstack-protector-strong', '-isystem', '/usr/local/include', '-fno-strict-aliasing', '-fno-omit-frame-pointer', '-MMD', '-D_GNU_SOURCE=1', '-D_XOPEN_SOURCE_EXTENDED=1', '-DHAVE_CONFIG_H=1', '-fPIC', '-D__STDC_WANT_LIB_EXT1__=1', '-D_REENTRANT', '-fstack-protector-strong', '-fstack-clash-protection', '-DSTATIC_SMBREADLINE_MODULES=NULL', '-DSTATIC_SMBREADLINE_MODULES_PROTO=extern void __SMBREADLINE_dummy_module_proto(void)', '-Ilibcli/smbreadline', '-I../../libcli/smbreadline', '-Iinclude/public', '-I../../include/public', '-Isource4', '-I../../source4', '-Ilib', '-I../../lib', '-Isource4/lib', '-I../../source4/lib', '-Isource4/include', '-I../../source4/include', '-Iinclude', '-I../../include', '-Ilib/replace', '-I../../lib/replace', '-I.', '-I../..', '-I/usr/local/include', '../../libcli/smbreadline/smbreadline.c', '-c', '-o/wrkdirs/usr/ports/net/samba419/work/samba-4.19.8/bin/default/libcli/smbreadline/smbreadline.c.1.o', '-DLIBICONV_PLUG', '-isystem', '/usr/local/include']
../../libcli/smbreadline/smbreadline.c:139:38: warning: 'CPPFunction' is deprecated [-Wdeprecated-declarations]
  139 |                 rl_attempted_completion_function = RL_COMPLETION_CAST completion_fn;
      |                                                    ^
../../lib/replace/system/readline.h:50:31: note: expanded from macro 'RL_COMPLETION_CAST'
   50 | #  define RL_COMPLETION_CAST (CPPFunction *)
      |                               ^
/usr/local/include/readline/rltypedefs.h:38:50: note: 'CPPFunction' has been explicitly marked deprecated here
   38 | typedef char **CPPFunction (void) __attribute__((deprecated));
      |                                                  ^
../../libcli/smbreadline/smbreadline.c:139:36: error: incompatible function pointer types assigning to 'rl_completion_func_t *' (aka 'char **(*)(const char *, int, int)') from 'CPPFunction *' (aka 'char **(*)(void)') [-Wincompatible-function-pointer-types]
  139 |                 rl_attempted_completion_function = RL_COMPLETION_CAST completion_fn;
      |                                                  ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning and 1 error generated.

Waf: Leaving directory `/wrkdirs/usr/ports/net/samba419/work/samba-4.19.8/bin/default'
Build failed
 -> task in 'SMBREADLINE' failed with exit status 1:
    {task 68195569700096: c smbreadline.c -> smbreadline.c.1.o}
['cc', '-D_SAMBA_BUILD_=4', '-DHAVE_CONFIG_H=1', '-O2', '-pipe', '-DLIBICONV_PLUG', '-fno-color-diagnostics', '-fstack-protector-strong', '-isystem', '/usr/local/include', '-fno-strict-aliasing', '-fno-omit-frame-pointer', '-MMD', '-D_GNU_SOURCE=1', '-D_XOPEN_SOURCE_EXTENDED=1', '-DHAVE_CONFIG_H=1', '-fPIC', '-D__STDC_WANT_LIB_EXT1__=1', '-D_REENTRANT', '-fstack-protector-strong', '-fstack-clash-protection', '-DSTATIC_SMBREADLINE_MODULES=NULL', '-DSTATIC_SMBREADLINE_MODULES_PROTO=extern void __SMBREADLINE_dummy_module_proto(void)', '-Ilibcli/smbreadline', '-I../../libcli/smbreadline', '-Iinclude/public', '-I../../include/public', '-Isource4', '-I../../source4', '-Ilib', '-I../../lib', '-Isource4/lib', '-I../../source4/lib', '-Isource4/include', '-I../../source4/include', '-Iinclude', '-I../../include', '-Ilib/replace', '-I../../lib/replace', '-I.', '-I../..', '-I/usr/local/include', '../../libcli/smbreadline/smbreadline.c', '-c', '-o/wrkdirs/usr/ports/net/samba419/work/samba-4.19.8/bin/default/libcli/smbreadline/smbreadline.c.1.o', '-DLIBICONV_PLUG', '-isystem', '/usr/local/include']
*** Error code 1

Stop.
make: stopped in /usr/ports/net/samba419
=>> Cleaning up wrkdir
===>  Cleaning for samba419-4.19.8_1
build of net/samba419 | samba419-4.19.8_1 ended at Wed Oct  2 09:49:59 CEST 2024
build time: 00:10:30
!!! build failure encountered !!!
`
Do you have any ideas? I don't see anything related in UPDATING file. I guess it's not a Samba issue, I have the same error with the two versions.

Thanks a lot.


Regards,
 
It's been having build issues on the FreeBSD repository builders too: https://portsfallout.com/fallout?port=net/samba416$

Got the same build error as you on net/samba416. Build at home seems to be fine though, not quite sure what the difference is, the options are the same on the failing build and at home. It's probably some interaction with an updated dependency. Haven't figured out which one yet.
 
That makes sense as the error in Samba seems to point to SMBREADLINE.
 
Back
Top