Solved Become a Port Maintainer

Leander

Leander

Hi,

I want to commit my changes to audio/firefly in order to get the port working again - but I don't understand where I can upload them. I didn't receive any username or password nor any link to commit e.g. Makefile, etc. I was expecting some kind of web interface or SVN account to apply them.

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=194883
https://www.freebsd.org/doc/en_US.ISO8859-1/articles/contributing-ports/
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/

Any hints or examples of how to commit a change to a port?

Thanks.
 
I see. It looks like one way is to make a diff of the Makefile and then share and PR it via port submit.
 
Only the people with commit rights can commit changes to the SVN repository. Port maintainers and other people without the commit rights need to upload their patches to the bug database on the appropriate PR where the patch is then marked as "maintainer approved" (look at the flag section of the uploaded patch if you are the maintainer) and a committer can then commit the patch. You need to create an account at https://bugs.freebsd.org/bugzilla/ if you don't already have one. If you have submitted PRs in the past before the change to Bugzilla you can probably use the email address you used then and use the "forgot password" function to create a new password for your account.
 
Leander said:
I see ... it looks like one way is to make a diff of the Makefile and then share & PR it via port submit.
Click to expand...
Note that this ports-mgmt/porttools command seemingly uses send-pr, which has been removed from FreeBSD 10.1.

Edit: BTW:
Code: 
ports-mgmt/porttools: upgrade to 1.03

- Upgrade to 1.03

Changelog:
- Mark port submit as broken
- Mark port followup as broken

PR: 194323
Differential Revision: https://reviews.freebsd.org/D992
Approved by: swills (mentor)
 
Juanitou said:
Note that this ports-mgmt/porttools command seemingly uses send-pr, which has been removed from FreeBSD 10.1.

Edit: BTW:
Code: 
ports-mgmt/porttools: upgrade to 1.03

- Upgrade to 1.03

Changelog:
- Mark port submit as broken
- Mark port followup as broken

PR: 194323
Differential Revision: https://reviews.freebsd.org/D992
Approved by: swills (mentor)
Click to expand...
Bizarre. /usr/bin/send-pr has been in BASE for as long as I can remember. In fact, I'm the maintainer of databases/gnats4, though it's been replaced by devel/bugzilla as the bug-tracking system. I guess I'll see if I can integrate devel/bugzilla into send-pr. It's such a great utility. I don't want to see it lost.

Thanks for pointing that out, Juanitou.

--Chris
 
Juanitou said:
Note that this ports-mgmt/porttools command seemingly uses send-pr, which has been removed from FreeBSD 10.1.

Edit: BTW:
Code: 
ports-mgmt/porttools: upgrade to 1.03

- Upgrade to 1.03

Changelog:
- Mark port submit as broken
- Mark port followup as broken

PR: 194323
Differential Revision: https://reviews.freebsd.org/D992
Approved by: swills (mentor)
Click to expand...


Chris_H said:
Bizarre. /usr/bin/send-pr has been in BASE, for as long as I can remember. In fact, I'm the maintainer of databases/gnats4, tho it's been replaced by devel/bugzilla, as the bug-tracking system. I guess I'll see if I can integrate devel/bugzilla into send-pr. It's such a great utility. I don't want to see it lost.

Thanks for pointing that out, Juanitou.

--Chris
Click to expand...

Thanks for your information. I would also have loved to be able to use an easy commit command like this port submit. But then again - I don't want to get used to something if it anyway disappears soon.

I did it manually now. Here is the link. Comments are most welcome.

PR 195224

Thanks.
 
Leander, thanks for maintaining!

As kpa pointed out, port maintainers don't automatically have commit rights. That's because pretty much anyone can become a port maintainer, while commits should be made only by people who know very well what's right and what's not. And besides ports themselves that also includes infrastructural stuff.

If I'm not mistaken work is being done to update the old send-pr so it can be used with Bugzilla just like it could in the past with GNATS. In the meantime you can submit changes using the Bugzilla web interface. If the e-mail address of your account matches the e-mail address listed as the maintainer of a port, you'll be recognised as such, which in turn means you can mark patches as maintainer-approved. In such a case, it's recommended that you put [PATCH, MAINTAINER UPDATE] (or something similar) at the beginning of the bug title. That might help getting a committer to take care of your changes as soon as possible. Including (links to) build logs from Poudriere and/or Redports may also help speed up the process. If you've checked your work with ports-mgmt/portlint, note that as well.
 
fonz said:
....

If I'm not mistaken work is being done to update the old send-pr so it can be used with Bugzilla just like it could in the past with GNATS.
...
Click to expand...
Yes. It's true. I'm working on it now... err... I'm responding to posts in the forums. But I'll get back to working on it when I'm done here. :)

I'm going to initiate a thread on this very subject here on the forums. Because, since this is part of BASE, it's ultimately going to affect most everyone. So I think it prudent to get feedback on the whole thing. But keep in mind; the first implementation will be as closely related to the original as possible. At least from the users' perspective.

All the best.

--Chris
 
Please note that even with maintainer approval it sometimes takes a while to get something committed. Fortunately we're past the STAGEDIR frenzy now, but still I get the impression that the committers are struggling to keep up with the stream of PRs. Maybe there just aren't enough (capable) committers to deal with the workload.
 
You must log in or register to reply here.
Back
Top