PDA

View Full Version : How to get my new devices committed?


mathuin
February 20th, 2009, 02:48
I use the RIGtalk and RIGblaster Plug and Play devices made by West Mountain Radio with my ham radio gear. The devices both use the Silicon Labs chip and I've modified usbdevs and uslcom.c to support the devices. How do I get these patches added to the kernel permanently so other folks can use them without having to patch -- and so I don't have to remember to patch after every 'make update'?

I've attached the patches to this post. Thanks for the help!

Djn
February 20th, 2009, 03:59
You could try mailing Jonathan Gray, who is mentioned in uslcom.c?

mathuin
February 20th, 2009, 04:09
An excellent idea. I just sent him a message. Thanks!

trev
February 20th, 2009, 05:11
You could also file a pr and attach the patches

mathuin
February 20th, 2009, 09:24
I got email back from Jonathan, he said he's not a FreeBSD committer and that the devices were already in OpenBSD. His patches are cosmetically different than mine -- if FreeBSD imports from Open on a regular basis I can just chill out and wait, right?

lme@
February 20th, 2009, 09:26
Please always submit a PR, so that your request is documented.
Then you can look for some committer who is convenient with the code and point him to the PR. With a little bit of luck it gets committed soon, then. :)

mathuin
February 20th, 2009, 21:10
I submitted a PR, attaching the two short patches as a concatenated text file. I'll keep my eyes out for action, if nothing happens in two or three weeks I'll see about nudging someone on one of the relevant mailing lists.